Discussion:
[GASPP PATCH] Use the correct variable $line instead of the implicit variable
(too old to reply)
Martin Storsjo
2018-10-22 20:24:12 UTC
Permalink
This fixes cases if the input parameter is something else than
the currently iterated variable.
---
gas-preprocessor.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 41d7b69..39ad08d 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -383,12 +383,12 @@ sub parse_line {
return if (parse_if_line($line));

if (scalar(@rept_lines) == 0) {
- if (/\.macro/) {
+ if ($line =~ /\.macro/) {
$macro_level++;
if ($macro_level > 1 && !$current_macro) {
die "nested macros but we don't have master macro";
}
- } elsif (/\.endm/) {
+ } elsif ($line =~ /\.endm/) {
$macro_level--;
if ($macro_level < 0) {
die "unmatched .endm";
--
2.7.4
Janne Grunau
2018-10-26 20:45:18 UTC
Permalink
Post by Martin Storsjo
This fixes cases if the input parameter is something else than
the currently iterated variable.
---
gas-preprocessor.pl | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl
index 41d7b69..39ad08d 100755
--- a/gas-preprocessor.pl
+++ b/gas-preprocessor.pl
@@ -383,12 +383,12 @@ sub parse_line {
return if (parse_if_line($line));
- if (/\.macro/) {
+ if ($line =~ /\.macro/) {
$macro_level++;
if ($macro_level > 1 && !$current_macro) {
die "nested macros but we don't have master macro";
}
- } elsif (/\.endm/) {
+ } elsif ($line =~ /\.endm/) {
$macro_level--;
if ($macro_level < 0) {
die "unmatched .endm";
ok

Janne

Loading...