Discussion:
[PATCH 2/3] lavc/qsvenc: fix a misleading log message
(too old to reply)
Zhong Li
2018-08-15 09:39:34 UTC
Permalink
Signed-off-by: Zhong Li <***@intel.com>
---
libavcodec/qsvenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
index c74b3ae..e7ca62f 100644
--- a/libavcodec/qsvenc.c
+++ b/libavcodec/qsvenc.c
@@ -1142,7 +1142,7 @@ static void print_interlace_msg(AVCodecContext *avctx, QSVEncContext *q)
q->param.mfx.CodecLevel > MFX_LEVEL_AVC_41)
av_log(avctx, AV_LOG_WARNING,
"Interlaced coding is supported"
- " at Main/High Profile Level 2.1-4.1\n");
+ " at Main/High Profile Level 2.2-4.0\n");
}
}
--
2.7.4
Zhong Li
2018-08-15 09:39:35 UTC
Permalink
H264/265 have been fixed such an issue with commit
559370f2c45110afd8308eec7194437736c323d4.
Similar fixing is needed for other codecs.

Signed-off-by: Zhong Li <***@intel.com>
---
libavcodec/qsvdec_other.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/libavcodec/qsvdec_other.c b/libavcodec/qsvdec_other.c
index 150ce0d..47934e9 100644
--- a/libavcodec/qsvdec_other.c
+++ b/libavcodec/qsvdec_other.c
@@ -138,8 +138,13 @@ static int qsv_decode_frame(AVCodecContext *avctx, void *data,
}

ret = ff_qsv_process_data(avctx, &s->qsv, frame, got_frame, &s->input_ref);
- if (ret < 0)
+ if (ret < 0) {
+ /* Drop input packet when failed to decode the packet. Otherwise,
+ the decoder will keep decoding the failure packet. */
+ av_packet_unref(&s->input_ref);
+
return ret;
+ }

s->input_ref.size -= ret;
s->input_ref.data += ret;
--
2.7.4
Luca Barbato
2018-08-16 11:17:55 UTC
Permalink
Solve some issues found by an automated code scansion.
Suppress the complain "variables 'handle' is used but maybe
uninitialized".
---
libavfilter/qsvvpp.c | 5 +++++
libavfilter/vf_deinterlace_qsv.c | 5 +++++
libavfilter/vf_scale_qsv.c | 5 +++++
3 files changed, 15 insertions(+)
The set looks good.

lu
Li, Zhong
2018-08-21 07:15:23 UTC
Permalink
Barbato
Sent: Thursday, August 16, 2018 7:18 PM
Subject: Re: [libav-devel] [PATCH 1/3] lavf/qsv: return an error if getting
session handle failed
Solve some issues found by an automated code scansion.
Suppress the complain "variables 'handle' is used but maybe
uninitialized".
---
libavfilter/qsvvpp.c | 5 +++++
libavfilter/vf_deinterlace_qsv.c | 5 +++++
libavfilter/vf_scale_qsv.c | 5 +++++
3 files changed, 15 insertions(+)
The set looks good.
lu
Thank you. Luca. Will be applied?
Luca Barbato
2018-08-22 11:20:58 UTC
Permalink
Post by Li, Zhong
Thank you. Luca. Will be applied?
I was waiting for Maxym's feedback, but sure, it can.

I'll push it this evening.

lu
Maxym Dmytrychenko
2018-08-22 14:50:28 UTC
Permalink
Post by Luca Barbato
Post by Li, Zhong
Thank you. Luca. Will be applied?
I was waiting for Maxym's feedback, but sure, it can.
I'll push it this evening.
lu
_______________________________________________
libav-devel mailing list
https://lists.libav.org/mailman/listinfo/libav-devel
was busy here but just fine!

thanks

regards
Max
Li, Zhong
2018-08-23 09:44:18 UTC
Permalink
Maxym Dmytrychenko
Sent: Wednesday, August 22, 2018 10:50 PM
Subject: Re: [libav-devel] [PATCH 1/3] lavf/qsv: return an error if getting
session handle failed
Post by Luca Barbato
Post by Li, Zhong
Thank you. Luca. Will be applied?
I was waiting for Maxym's feedback, but sure, it can.
I'll push it this evening.
lu
_______________________________________________
libav-devel mailing list
https://lists.libav.org/mailman/listinfo/libav-devel
was busy here but just fine!
thanks
regards
Max
I see patch set merged. Thank you Luca/Maxym.

Loading...